perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

* perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline Two chunks rode along in the first-load JS of almost every dashboard route: the full BAS 2026 chart (315 KB uncompressed, in 81 route manifests) and the browser polyfill for Node's crypto/vm/Buffer (327 KB, in 26 routes incl. login and register). Neither was needed on first paint; both got there through static imports of helpers that happen to live next to code that needs the data or the builtin. Node polyfill (4 pure splits, behaviour unchanged, re-exported from the original modules for server callers): - lib/auth/bankid-flags.ts: isBankIdEnabled (login, register, security settings imported it from bankid.ts, which imports crypto). - lib/import/bank-file/formats.ts: the format registry + detection (the import history imported getFormat from parser.ts, which hashes). - lib/salary/personnummer-format.ts: parsing/validation/formatting (the employee forms reached the encrypting personnummer.ts via tax-column). - lib/auth/api-key-scopes.ts: scope catalogue, groups, tool map, helpers (the API key panel imported STAGING_SCOPES from the key generator). BAS chart: - lib/bookkeeping/bas-lazy.ts + use-bas-reference.ts: the chart becomes a dynamic import, fetched once per session after first paint; components that show BAS names/descriptions call useBasReference() and re-render when it lands. Until then (and on the server) only the hardcoded account-descriptions answer, so SSR and hydration agree. - lib/bookkeeping/bas-labels.ts: class/group labels out of bas-reference.ts (account-descriptions needed a label and paid for the whole chart). - lib/bookkeeping/bas-account-numbers.ts (generated, ~11 KB) + scripts/generate-bas-account-numbers.ts (--check) + parity test: isStandardBASAccountNumber for AddAccountDialog/ChartOfAccountsManager. - lib/bookkeeping/account-classifier-{heuristic,client}.ts: the BAS-aligned heuristic shared by the server classifier and a client variant that uses the lazy chart. - lib/bookkeeping/invoice-accounts.ts: INVOICE_FX_RATE_MISSING, InvoiceFxRateMissingError, getRevenueAccount, getOutputVatAccount out of invoice-entries.ts, whose engine import pulled account-backfill and the chart into SendInvoiceDialog/PaymentBookingDialog. - CorrectOpeningBalanceDialog re-seeds names when the chart lands; OpeningBalanceRowEditor builds its Fuse indexes lazily; the ChartOfAccountsManager BAS-katalog tab awaits the chunk. Tooling: - scripts/perf/client-import-closure.mjs: static import closure of every 'use client' module with the shortest chain to a target (file or bare specifier); found every path above without a build. - scripts/checks/client-node-builtin.mjs wired into check:guards: a client module reaching a Node builtin is a hard failure (0 today). Left as is: invoices/[id], its credit page and SendInvoiceDialog still reach the chart through lib/invoices/issue-credit-note -> invoice-entries -> engine -> account-backfill; splitting the engine is out of scope here. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(perf): unambiguous import-edge regex in the closure walker (CodeQL js/redos) One quantifier per span: a greedy [^'"]* up to the specifier quote, which it cannot cross, so a run of whitespace has a single parse. Same edges as before (multi-line named imports, re-exports, side-effect imports; type-only imports still skipped). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-26 15:07:49 +02:00
parent e7e4efbfbc
commit 1a41119682
38 changed files with 1235 additions and 533 deletions
@@ -0,0 +1,74 @@
+/**
+ * Bank file format registry: which parsers exist and how a file is matched
+ * to one. Split from parser.ts, which also hashes content with `crypto`,
+ * so client code can resolve a format id to its label without the browser
+ * crypto polyfill.
+ */
+
+import type { BankFileFormat, BankFileFormatId } from './types'
+import { nordeaFormat } from './formats/nordea'
+import { nordeaBusinessFormat } from './formats/nordea-business'
+import { sebFormat } from './formats/seb'
+import { swedbankFormat } from './formats/swedbank'
+import { handelsbankenFormat } from './formats/handelsbanken'
+import { lansforsakringarFormat } from './formats/lansforsakringar'
+import { icaBankenFormat } from './formats/ica-banken'
+import { skandiaFormat } from './formats/skandia'
+import { lunarFormat } from './formats/lunar'
+import { northmillFormat } from './formats/northmill'
+import { wiseFormat } from './formats/wise'
+import { wiseStatementFormat } from './formats/wise-statement'
+import { camt053Format } from './formats/camt053'
+import { genericCSVFormat } from './formats/generic-csv'
+
+/**
+ * Ordered list of format detectors.
+ * camt.053 first (XML detection is unambiguous), then bank-specific CSV formats.
+ * New bank formats go after existing ones but before generic_csv.
+ * Generic CSV is last: it never auto-detects (manual fallback only).
+ */
+const FORMATS: BankFileFormat[] = [
+  camt053Format,
+  nordeaFormat,
+  nordeaBusinessFormat,
+  sebFormat,
+  swedbankFormat,
+  handelsbankenFormat,
+  lansforsakringarFormat,
+  icaBankenFormat,
+  skandiaFormat,
+  lunarFormat,
+  northmillFormat,
+  wiseFormat,
+  wiseStatementFormat,
+  genericCSVFormat,
+]
+
+/**
+ * Get a format by its ID
+ */
+export function getFormat(id: BankFileFormatId): BankFileFormat | undefined {
+  return FORMATS.find((f) => f.id === id)
+}
+
+/**
+ * Get all available formats
+ */
+export function getAllFormats(): BankFileFormat[] {
+  return FORMATS
+}
+
+/**
+ * Auto-detect the bank file format from content and filename
+ *
+ * Returns the first matching format, or null if no format matches.
+ * Uses filename extension as a hint (e.g. .xml for camt.053).
+ */
+export function detectFileFormat(content: string, filename: string): BankFileFormat | null {
+  for (const format of FORMATS) {
+    if (format.detect(content, filename)) {
+      return format
+    }
+  }
+  return null
+}
@@ -7,72 +7,12 @@

 import * as crypto from 'crypto'
 import type { BankFileFormat, BankFileFormatId, BankFileParseResult, ParsedBankTransaction } from './types'
-import { nordeaFormat } from './formats/nordea'
-import { nordeaBusinessFormat } from './formats/nordea-business'
-import { sebFormat } from './formats/seb'
-import { swedbankFormat } from './formats/swedbank'
-import { handelsbankenFormat } from './formats/handelsbanken'
-import { lansforsakringarFormat } from './formats/lansforsakringar'
-import { icaBankenFormat } from './formats/ica-banken'
-import { skandiaFormat } from './formats/skandia'
-import { lunarFormat } from './formats/lunar'
-import { northmillFormat } from './formats/northmill'
-import { wiseFormat } from './formats/wise'
-import { wiseStatementFormat } from './formats/wise-statement'
-import { camt053Format } from './formats/camt053'
-import { genericCSVFormat } from './formats/generic-csv'

-/**
- * Ordered list of format detectors.
- * camt.053 first (XML detection is unambiguous), then bank-specific CSV formats.
- * New bank formats go after existing ones but before generic_csv.
- * Generic CSV is last: it never auto-detects (manual fallback only).
- */
-const FORMATS: BankFileFormat[] = [
-  camt053Format,
-  nordeaFormat,
-  nordeaBusinessFormat,
-  sebFormat,
-  swedbankFormat,
-  handelsbankenFormat,
-  lansforsakringarFormat,
-  icaBankenFormat,
-  skandiaFormat,
-  lunarFormat,
-  northmillFormat,
-  wiseFormat,
-  wiseStatementFormat,
-  genericCSVFormat,
-]
-
-/**
- * Get a format by its ID
- */
-export function getFormat(id: BankFileFormatId): BankFileFormat | undefined {
-  return FORMATS.find((f) => f.id === id)
-}
-
-/**
- * Get all available formats
- */
-export function getAllFormats(): BankFileFormat[] {
-  return FORMATS
-}
-
-/**
- * Auto-detect the bank file format from content and filename
- *
- * Returns the first matching format, or null if no format matches.
- * Uses filename extension as a hint (e.g. .xml for camt.053).
- */
-export function detectFileFormat(content: string, filename: string): BankFileFormat | null {
-  for (const format of FORMATS) {
-    if (format.detect(content, filename)) {
-      return format
-    }
-  }
-  return null
-}
+// The format registry and detection live in ./formats (no Node imports) so
+// client components (BankFileImportHistory) can name a format without
+// pulling this module's `crypto` import into the browser bundle.
+import { detectFileFormat, getAllFormats, getFormat } from './formats'
+export { detectFileFormat, getAllFormats, getFormat } from './formats'

 /**
 * Parse a bank file with auto-detection or explicit format
@@ -137,7 +77,7 @@ export function parseBankFile(
    format = detectFileFormat(content, filename) || undefined
    if (!format) {
      // Build diagnostic message listing which formats were tried
-      const tried = FORMATS
+      const tried = getAllFormats()
        .filter(f => f.id !== 'generic_csv')
        .map(f => f.name)
      const firstLine = content.split('\n')[0]?.substring(0, 80) || ''