From 0ecf1d7fc4f9acd9a7e2acd10752f5f4025c323d Mon Sep 17 00:00:00 2001 From: Jakob Wennberg Date: Sat, 5 Sep 2026 18:07:01 +0200 Subject: [PATCH] =?UTF-8?q?fix(expenses):=20no=20help=20line=20for=20"F?= =?UTF-8?q?=C3=B6retaget"=20in=20the=20Vem=20betalade=20select=20(#2330)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The button under it already says "Matcha mot transaktion", so the line "Kort eller bankkonto. Matchas mot transaktionen när den syns." repeated it. The other answers keep their line: it names the liability the company takes on. Claude-Session: https://claude.ai/code/session_01P8YsvPqjfGxGZUkGeBVUWQ Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 --- .../general/InvoiceInboxWorkspace.tsx | 18 ++++++++++++++---- messages/en.json | 1 - messages/sv.json | 1 - 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/components/extensions/general/InvoiceInboxWorkspace.tsx b/components/extensions/general/InvoiceInboxWorkspace.tsx index 31b4ace9..cddc7e18 100644 --- a/components/extensions/general/InvoiceInboxWorkspace.tsx +++ b/components/extensions/general/InvoiceInboxWorkspace.tsx @@ -3116,8 +3116,16 @@ export function PayerChoiceSelect({ accountingMethod: AccountingMethod }) { const t = useTranslations('inbox_workspace') - const helpKey = (choice: PayerChoice): string => - choice === 'unpaid' && accountingMethod === 'cash' ? 'payer_help_unpaid_cash' : `payer_help_${choice}` + // Företaget carries no help line: the button under it ("Matcha mot + // transaktion") already says what happens. The other answers name the + // liability the company takes on, which is the consequence worth reading. + const helpKey = (choice: PayerChoice): string | null => + choice === 'company' + ? null + : choice === 'unpaid' && accountingMethod === 'cash' + ? 'payer_help_unpaid_cash' + : `payer_help_${choice}` + const selectedHelp = helpKey(value) return (

{t('payer_question')}

@@ -3133,12 +3141,14 @@ export function PayerChoiceSelect({ {PAYER_ORDER.map((choice) => ( {t(`payer_${choice}`)} - {t(helpKey(choice))} + {helpKey(choice) && ( + {t(helpKey(choice)!)} + )} ))} -

{t(helpKey(value))}

+ {selectedHelp &&

{t(selectedHelp)}

}
) } diff --git a/messages/en.json b/messages/en.json index b0a76828..10b91cb8 100644 --- a/messages/en.json +++ b/messages/en.json @@ -3304,7 +3304,6 @@ "inbox_workspace": { "payer_question": "Who paid?", "payer_company": "The company", - "payer_help_company": "Card or bank account. Matched against the transaction when it appears.", "payer_owner": "Me, privately", "payer_help_owner": "The company owes you the amount. Paid out from the company account later.", "payer_employee": "An employee", diff --git a/messages/sv.json b/messages/sv.json index b614bf72..9a051a77 100644 --- a/messages/sv.json +++ b/messages/sv.json @@ -3304,7 +3304,6 @@ "inbox_workspace": { "payer_question": "Vem betalade?", "payer_company": "Företaget", - "payer_help_company": "Kort eller bankkonto. Matchas mot transaktionen när den syns.", "payer_owner": "Jag, privat", "payer_help_owner": "Bolaget blir skyldigt dig beloppet. Betalas ut från företagskontot senare.", "payer_employee": "En anställd",