feat(reconciliation): match migrated bank history against imported SIE verifikat (#1598)
* feat(reconciliation): match migrated bank history against imported SIE verifikat A first-class Fortnox/SIE migrator path: after SIE import plus bank connect or bank CSV upload, historical bank rows are auto-matched (>= 0.9) or suggestion-matched (0.75-0.89, persisted for review) against the imported verifikat, with a guided review surface, instead of landing as anonymous "Att bokfora" rows. Phase 0: per-cash-account unattended sweep (fixes #1298 cross-account pooling); widen payment_match_log action CHECK with linked_to_existing_voucher (silently unlogged since March). Phase 1: potential_journal_entry_id/method/confidence on transactions with CHECK + invalidation triggers; persistSuggestions in runReconciliation; sweep after bank CSV import with SIE overlap (suppressing auto-categorization); sweep summaries stamped on bank_connections and bank_file_imports; POST /api/reconciliation/bank/confirm-suggestions with per-pair server-side revalidation (voucher consumption + bank-leg amount and direction). Phase 2: "Granska forslag" review tab on Transactions with chunked bulk confirm, per-row fallbacks, "Kor matchning igen" (all_accounts sweep mode, mutually exclusive with dry_run), attn line, pre-migration row marker. Phase 3: ImportResultStep dual CTA (bank connect + CSV), migrator variant of the account-picker #917 nudge, sweep outcome on the onboarding checklist bank step. Non-selection apply runs on /api/reconciliation/bank/run now floor at 0.9 and persist the review band instead of auto-committing fuzzy matches. Migrations already applied to staging under the same versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): resolve PR review findings in one pass Swedish accounting review (both previously-deferred holes closed): - runReconciliation's >= 0.9 auto-apply now writes 'matched' to payment_match_log (behandlingshistorik, BFNAR 2013:2 kap 8); the bus event alone lands in the 30-day event_log and is not an audit record. - The three match-route storno-conflict branches detach reconciliation links via unlinkReconciliation instead of storno-reversing the linked verifikat: a reconciliation link points at an independent verifikat that may evidence other affarshandelser, and a wholesale reversal is an over-broad rattelse (BFL 5 kap 5 §). - Historical gap quantified on prod (read-only, recorded in DECISIONS): 762 unlogged manual links across 52 companies since 2026-03-23. CodeRabbit: - confirm-suggestions route: maxDuration 300 for full 500-item batches. - AccountPickerDialog: migrator-nudge buttons set lookbackTouched so the async gap-fill probe cannot override an explicit choice. - enable-banking post-backfill sweep: persistSuggestions so the review band is not dropped. - bank-file execute: sie_sweep stamp errors are logged, not swallowed. - ImportResultStep: sandbox keeps the CSV CTA (file import works there). - payment_match_log CHECK swap: NOT VALID + VALIDATE, no table scan under ACCESS EXCLUSIVE. - logMatchEvent calls awaited (serverless can freeze unawaited work). - DECISIONS.md stale version reference annotated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): defer reconciliation-link detach until the match commits Round-2 review findings: - CodeRabbit: the eager unlinkReconciliation call could orphan a transaction if the match flow failed after it. All three match routes now persist NOTHING up front: the final transaction update overwrites journal_entry_id and clears reconciliation_method in the same write, so any failure in between leaves the existing link intact. The release is logged as 'unmatched' after the commit. - Swedish review: the auto_suggested logMatchEvent in runReconciliation is now awaited like every other audit write. - DECISIONS entry split into compliance/CodeRabbit lines and updated to describe the deferred detach. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): literal reconciliation_method payloads for the phantom-column scanner The conditional spreads introduced with the deferred detach pushed the scanner's unresolvable-expression count past its ceiling (380 > 378). reconciliation_method: null is correct unconditionally on a confirmed invoice/supplier match (null is already the value on every row that was not reconciliation-linked), so the payloads become plain literals the guard can verify. No behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Fable 5
Claude Fable 5
parent
07e89d9b52
commit
08440fed94
@@ -29,6 +29,12 @@ interface NewUserChecklistProps {
|
||||
hasAgentBuilt?: boolean
|
||||
/** Personalized VAT-deadline line for the Skatteverket step (null = say nothing). */
|
||||
vatLine?: VatDeadlineLine
|
||||
/** Latest SIE reconciliation-sweep outcome: surfaces "X matchade, Y att
|
||||
* granska" on the bank step so a migrator sees what the sweep did with
|
||||
* their history. Null = no sweep has run, say nothing. A sweep with
|
||||
* errors > 0 was incomplete (a whole account may have been skipped), so it
|
||||
* also says nothing rather than presenting partial numbers as the result. */
|
||||
sieSweep?: { auto_linked: number; suggested: number; unmatched: number; errors: number } | null
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -69,6 +75,7 @@ export default function NewUserChecklist({
|
||||
hasInboxItems = false,
|
||||
hasAgentBuilt = false,
|
||||
vatLine = null,
|
||||
sieSweep = null,
|
||||
}: NewUserChecklistProps) {
|
||||
const t = useTranslations('initial_setup')
|
||||
const router = useRouter()
|
||||
@@ -292,6 +299,22 @@ export default function NewUserChecklist({
|
||||
<LogoMark src="/logos/enable-banking-icon.png" name="Enable Banking" mono />
|
||||
) : undefined
|
||||
}
|
||||
doneNote={
|
||||
step2Done &&
|
||||
sieSweep &&
|
||||
sieSweep.errors === 0 &&
|
||||
(sieSweep.auto_linked > 0 || sieSweep.suggested > 0) ? (
|
||||
<Link
|
||||
href="/transactions"
|
||||
className="underline decoration-border underline-offset-4 transition-colors hover:text-foreground"
|
||||
>
|
||||
{t('step_bank_sweep_note', {
|
||||
matched: sieSweep.auto_linked,
|
||||
toReview: sieSweep.suggested,
|
||||
})}
|
||||
</Link>
|
||||
) : undefined
|
||||
}
|
||||
>
|
||||
{t('step_bank_description')}
|
||||
</Step>
|
||||
@@ -398,6 +421,7 @@ function Step({
|
||||
badge,
|
||||
action,
|
||||
marks,
|
||||
doneNote,
|
||||
last = false,
|
||||
children,
|
||||
}: {
|
||||
@@ -408,6 +432,10 @@ function Step({
|
||||
badge?: string
|
||||
action?: (variant: 'default' | 'outline') => React.ReactNode
|
||||
marks?: React.ReactNode
|
||||
/** Small note rendered next to the title once the step is DONE: the one
|
||||
* exception to "done steps collapse to their title" (e.g. the bank step's
|
||||
* sweep outcome, which is the payoff the migrator is waiting for). */
|
||||
doneNote?: React.ReactNode
|
||||
last?: boolean
|
||||
children: React.ReactNode
|
||||
}) {
|
||||
@@ -455,6 +483,9 @@ function Step({
|
||||
)}
|
||||
</div>
|
||||
{!done && action?.(open ? 'default' : 'outline')}
|
||||
{done && doneNote && (
|
||||
<span className="text-xs tabular-nums text-muted-foreground">{doneNote}</span>
|
||||
)}
|
||||
</div>
|
||||
{open && (
|
||||
<div className="mt-1 flex flex-wrap items-center gap-x-3 gap-y-2">
|
||||
|
||||
Reference in New Issue
Block a user