feat(transactions): underlag status badges + attach dialog; auto-expire stale pending ops (#712)

* feat(transactions): per-row underlag status + attach-document dialog - New "Matcha mot underlag" dialog on /transactions (inbox pick or fresh upload), the tx→doc mirror of the Documents view's matcher - Per-row Underlag/Underlag saknas badges on booked history rows, driven by computeJeUnderlagStatus — same posted-only, exemption-aware scope as the worklist count so badge and count never disagree - attach-document route + commit dispatcher now propagate the doc onto the verifikation when the tx is already booked (BFL 5 kap 6 §), with a 409 guard for docs consumed by a different verifikation, idempotent re-attach (no same-value rewrite under period lock), and an honest 409 when the period-lock trigger blocks the propagation - Booking-dialog doc links also pin the doc to the transaction row (first linked doc wins) via the link route's new transaction_id param messages/{sv,en}.json also carries the strings for the pending-ops expiry UI that lands in the next commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(pending-operations): auto-expire stale staged operations after 30 days - New daily cron (02:30 UTC, vercel.json + both docker crontabs) flips >30-day-old pending ops to rejected with the dispatcher's { auto_rejected: true, reason: 'expired' } result_data shape — rows are never deleted, the table is the audit trail - /pending renders an "Utgick automatiskt" badge + detail line for these, orders terminal tabs by resolved_at so a fresh expiry sweep isn't buried, and adds a first-time-reviewer explainer - Origin labels spell out where a proposal came from (AI chat, MCP key, API, cron) instead of the raw actor_label - agent_chat actor type added to PendingOperationActorType/AuditLogEntry (DB CHECK already widened in 20260519090000) and to the agent filter - ApprovalCard notes that ignoring a proposal is safe Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(mcp): surface the client telemetry marker in connect instructions Tag the connector URLs shown in ApiKeysPanel, the connect-claude doc and the gnubok-mcp README with ?client=<surface> (claude-connector / claude-code) and GNUBOK_CLIENT=claude-desktop for the npm bridge. Telemetry-only — the server already reads the param/header; this just lets us measure which Claude surface connected. The claude mcp add copy blocks quote the URL: an unquoted ? in the query string trips zsh globbing ("no matches found"). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * review: fix stale-closure badge flip + zod-validate link route body (PR #712) - handleDocumentAttached read journal_entry_id off the render-time transactions snapshot; if the list changed while the attach dialog was open the optimistic badge flip was silently skipped. Read it off the dialog's own subject (attachDocTx) instead. - POST /api/documents/[id]/link now validates the body against the new LinkDocumentSchema (uuid-strict, all four fields) instead of a bare presence check on journal_entry_id — same canonical VALIDATION_ERROR envelope. Test fixtures switched to real UUIDs accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-06-11 11:13:51 +02:00
parent e978136210
commit 0521c385d2
29 changed files with 1457 additions and 104 deletions
@@ -30,6 +30,14 @@ import { NextResponse } from 'next/server'

 const mockUser = { id: 'user-1', email: 'test@test.se' }

+// Body fields are uuid-validated (LinkDocumentSchema) — request fixtures must
+// be real UUIDs. The enqueue mock rows keep their short ids; the queued mock
+// doesn't correlate request input with mocked output.
+const JE_ID = '11111111-1111-4111-8111-111111111111'
+const OTHER_JE_ID = '22222222-2222-4222-8222-222222222222'
+const INBOX_ID = '33333333-3333-4333-8333-333333333333'
+const TX_ID = '44444444-4444-4444-8444-444444444444'
+
 beforeEach(() => {
  vi.clearAllMocks()
  reset()
@@ -49,7 +57,7 @@ function makeReq(body: unknown) {
 describe('POST /api/documents/[id]/link', () => {
  it('returns 401 when not authenticated', async () => {
    mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
-    const res = await POST(makeReq({ journal_entry_id: 'je-1' }), createMockRouteParams({ id: 'doc-1' }))
+    const res = await POST(makeReq({ journal_entry_id: JE_ID }), createMockRouteParams({ id: 'doc-1' }))
    const { status } = await parseJsonResponse(res)
    expect(status).toBe(401)
  })
@@ -62,7 +70,7 @@ describe('POST /api/documents/[id]/link', () => {
        { status: 403 },
      ),
    })
-    const res = await POST(makeReq({ journal_entry_id: 'je-1' }), createMockRouteParams({ id: 'doc-1' }))
+    const res = await POST(makeReq({ journal_entry_id: JE_ID }), createMockRouteParams({ id: 'doc-1' }))
    const { status } = await parseJsonResponse(res)
    expect(status).toBe(403)
  })
@@ -73,13 +81,24 @@ describe('POST /api/documents/[id]/link', () => {
    expect(body.error.code).toBe('VALIDATION_ERROR')
  })

+  it('rejects a non-uuid journal_entry_id', async () => {
+    const res = await POST(
+      makeReq({ journal_entry_id: 'not-a-uuid' }),
+      createMockRouteParams({ id: 'doc-1' }),
+    )
+    const { status, body } = await parseJsonResponse<{ error: { code: string } }>(res)
+    expect(status).toBe(400)
+    expect(body.error.code).toBe('VALIDATION_ERROR')
+    expect(mockSupabase.from).not.toHaveBeenCalled()
+  })
+
  it('links the document and stamps the inbox item when inbox_item_id is given', async () => {
    enqueue({ data: { id: 'je-1' } }) // journal entry company check
    enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
    enqueue({ data: null }) // inbox stamp update

    const res = await POST(
-      makeReq({ journal_entry_id: 'je-1', inbox_item_id: 'inbox-1' }),
+      makeReq({ journal_entry_id: JE_ID, inbox_item_id: INBOX_ID }),
      createMockRouteParams({ id: 'doc-1' }),
    )
    const { status, body } = await parseJsonResponse<{ data: { id: string } }>(res)
@@ -95,7 +114,7 @@ describe('POST /api/documents/[id]/link', () => {
    enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update

    const res = await POST(
-      makeReq({ journal_entry_id: 'je-1' }),
+      makeReq({ journal_entry_id: JE_ID }),
      createMockRouteParams({ id: 'doc-1' }),
    )
    const { status } = await parseJsonResponse(res)
@@ -104,6 +123,51 @@ describe('POST /api/documents/[id]/link', () => {
    expect(mockSupabase.from).not.toHaveBeenCalledWith('invoice_inbox_items')
  })

+  it('pins the document to the transaction when transaction_id is given', async () => {
+    enqueue({ data: { id: 'je-1' } }) // journal entry company check
+    enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
+    enqueue({ data: null }) // transaction pin update
+
+    const res = await POST(
+      makeReq({ journal_entry_id: JE_ID, transaction_id: TX_ID }),
+      createMockRouteParams({ id: 'doc-1' }),
+    )
+    const { status } = await parseJsonResponse(res)
+
+    expect(status).toBe(200)
+    expect(mockSupabase.from).toHaveBeenCalledWith('transactions')
+  })
+
+  it('does not touch transactions when no transaction_id is given', async () => {
+    enqueue({ data: { id: 'je-1' } }) // journal entry company check
+    enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
+
+    const res = await POST(
+      makeReq({ journal_entry_id: JE_ID }),
+      createMockRouteParams({ id: 'doc-1' }),
+    )
+    const { status } = await parseJsonResponse(res)
+
+    expect(status).toBe(200)
+    expect(mockSupabase.from).not.toHaveBeenCalledWith('transactions')
+  })
+
+  it('tolerates a failing transaction pin — the JE link is the primary effect', async () => {
+    enqueue({ data: { id: 'je-1' } }) // journal entry company check
+    enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
+    enqueue({ data: null, error: { message: 'rls denied' } }) // transaction pin fails
+
+    const res = await POST(
+      makeReq({ journal_entry_id: JE_ID, transaction_id: TX_ID }),
+      createMockRouteParams({ id: 'doc-1' }),
+    )
+    const { status, body } = await parseJsonResponse<{ data: { id: string } }>(res)
+
+    // The pin is row-level UX; its failure must not fail the (compliant) link.
+    expect(status).toBe(200)
+    expect(body.data.id).toBe('doc-1')
+  })
+
  it('maps a period-lock trigger error to PERIOD_LOCKED', async () => {
    enqueue({ data: { id: 'je-1' } }) // journal entry company check
    enqueue({
@@ -111,7 +175,7 @@ describe('POST /api/documents/[id]/link', () => {
      error: { message: 'new row violates ... locked/closed fiscal period' },
    })
    const res = await POST(
-      makeReq({ journal_entry_id: 'je-1', inbox_item_id: 'inbox-1' }),
+      makeReq({ journal_entry_id: JE_ID, inbox_item_id: INBOX_ID }),
      createMockRouteParams({ id: 'doc-1' }),
    )
    const { body } = await parseJsonResponse<{ error: { code: string } }>(res)
@@ -127,7 +191,7 @@ describe('POST /api/documents/[id]/link', () => {
      error: { message: 'document already linked to another entry' },
    })
    const res = await POST(
-      makeReq({ journal_entry_id: 'je-1' }),
+      makeReq({ journal_entry_id: JE_ID }),
      createMockRouteParams({ id: 'doc-1' }),
    )
    const { body } = await parseJsonResponse<{ error: { code: string } }>(res)
@@ -139,7 +203,7 @@ describe('POST /api/documents/[id]/link', () => {
    // bogus or belongs to another tenant. The document must never be updated.
    enqueue({ data: null }) // journal entry company check → no match
    const res = await POST(
-      makeReq({ journal_entry_id: 'je-other-company' }),
+      makeReq({ journal_entry_id: OTHER_JE_ID }),
      createMockRouteParams({ id: 'doc-1' }),
    )
    const { body } = await parseJsonResponse<{ error: { code: string } }>(res)
@@ -3,13 +3,14 @@ import { ensureInitialized } from '@/lib/init'
 import { linkToJournalEntry } from '@/lib/core/documents/document-service'
 import { withRouteContext } from '@/lib/api/with-route-context'
 import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
+import { LinkDocumentSchema } from '@/lib/api/schemas'

 ensureInitialized()

 /**
 * POST /api/documents/[id]/link — link a document to a journal entry.
 *
- * Body: { journal_entry_id: string, journal_entry_line_id?: string, inbox_item_id?: string }
+ * Body: { journal_entry_id: string, journal_entry_line_id?: string, inbox_item_id?: string, transaction_id?: string }
 *
 * When `inbox_item_id` is supplied (the "choose from inbox" flow), the inbox
 * item is stamped with the verifikat id after a successful link so it drops out
@@ -18,6 +19,14 @@ ensureInitialized()
 * write and happens first; the inbox stamp is operational housekeeping, so a
 * stamp failure is logged but does not fail the request (the doc is correctly
 * attached and the DB immutability trigger still blocks any double-link).
+ *
+ * When `transaction_id` is supplied (booking-flow callers that link underlag
+ * right after booking a bank transaction), the doc is also pinned to the
+ * transaction row (transactions.document_id) so the /transactions list shows
+ * the underlag indicator. Only set when the tx has no pin yet — first linked
+ * doc wins, and an existing räkenskapsinformation pin is never swapped (which
+ * would trip the immutability trigger). Same best-effort posture as the inbox
+ * stamp: a failure is logged but does not fail the request.
 */
 export const POST = withRouteContext(
  'document.link',
@@ -26,14 +35,19 @@ export const POST = withRouteContext(
    const { supabase, companyId, log, requestId } = ctx
    const opLog = log.child({ documentId: id })

-    const body = await request.json().catch(() => ({}))
-
-    if (!body.journal_entry_id) {
+    const parsed = LinkDocumentSchema.safeParse(await request.json().catch(() => null))
+    if (!parsed.success) {
      return errorResponseFromCode('VALIDATION_ERROR', opLog, {
        requestId,
-        details: { field: 'journal_entry_id', reason: 'required' },
+        details: {
+          issues: parsed.error.issues.map((i) => ({
+            field: i.path.join('.'),
+            reason: i.message,
+          })),
+        },
      })
    }
+    const body = parsed.data

    try {
      const document = await linkToJournalEntry(
@@ -72,6 +86,25 @@ export const POST = withRouteContext(
        }
      }

+      if (body.transaction_id) {
+        const { error: pinError } = await supabase
+          .from('transactions')
+          .update({ document_id: id })
+          .eq('id', body.transaction_id)
+          .eq('company_id', companyId!)
+          // Never swap an existing pin: keeps "first linked doc wins" semantics
+          // for multi-doc bookings and avoids the BFL immutability trigger.
+          .is('document_id', null)
+        if (pinError) {
+          // Non-fatal — the verifikat ↔ underlag link already succeeded; the
+          // pin is row-level UX on the /transactions list.
+          opLog.warn('transaction pin after link failed', {
+            transactionId: body.transaction_id,
+            reason: pinError.message,
+          })
+        }
+      }
+
      return NextResponse.json({ data: document })
    } catch (err) {
      opLog.error('document link failed', err as Error, {