Claude Opus 5
c864c8c417
CI (SIAX Cloud) / integration (push) Successful in 40s
CI (SIAX Cloud) / quality (push) Successful in 55s
CI (SIAX Cloud) / security (push) Successful in 21s
Security Scan (SIAX Cloud) / security (push) Successful in 22s
CI (SIAX Cloud) / integration (pull_request) Successful in 39s
CI (SIAX Cloud) / quality (pull_request) Successful in 54s
Security Scan (SIAX Cloud) / security (pull_request) Successful in 21s
CI (SIAX Cloud) / security (pull_request) Successful in 25s
Two corrections, both of my own errors.
1. SCOPE CREEP, NOW REVERTED. Running `prettier --write` on whole directories
reformatted 18 files this branch had no business touching — the entire
merged BI-P002..P012 core (arrow/, domain/, engine/, repositories/, five
analytics integration suites) and, absurdly,
search-opensearch.integration.test.ts, which has nothing to do with this
work. The changes were purely stylistic quote churn, but they added ~1,400
lines of noise to the diff, made the PR harder to review honestly, and
invited conflicts with the four other lanes working in this estate. All 18
are now byte-identical to origin/main again (verified with `git diff
origin/main --name-only`, which reports nothing for them). Formatting is now
applied only to the files this branch actually owns.
2. A COMMIT MESSAGE THAT DESCRIBED A FIX THAT WAS NOT IN THE CODE. Commit
3ee0230 said the "does NOT ship the Iceberg table" assertion had been moved
from a filesystem check to `git ls-files`. It had not. The patch anchor used
double quotes, prettier had already converted that file to single quotes, so
the replacement silently matched nothing and the script printed its success
line anyway. The suite then passed — but only because I had just deleted the
fixture directory, so the OLD filesystem assertion happened to be true.
That is precisely the failure mode this branch keeps writing tests against:
a green run that means something different from what it appears to mean. The
fix is now genuinely applied and verified the way it should have been the
first time — by running the suite WITH the Iceberg fixture present on disk,
which is the case that previously failed. It passes, and it now also asserts
that the parquet/csv fixtures ARE tracked, so a version shipping no fixture
at all would fail rather than pass vacuously.
957 tests pass with ClickHouse, Postgres and DuckDB live. typecheck, eslint and
prettier clean on the files this branch owns.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>