CI (SIAX Cloud) / security (push) Successful in 22s
Security Scan (SIAX Cloud) / security (push) Successful in 20s
CI (SIAX Cloud) / quality (push) Successful in 39s
Security Scan (SIAX Cloud) / security (pull_request) Successful in 24s
CI (SIAX Cloud) / security (pull_request) Successful in 25s
CI (SIAX Cloud) / quality (pull_request) Successful in 40s
A live compliance audit against 0pt.app confirmed both endpoints returned
HTTP 200 with zero authentication -- the full order queue and financial
pipeline aggregates (deposit/pipeline totals) were readable by anyone.
Root cause: middleware.ts's matcher only covers /api/0pt/:path*, by design
("does NOT touch ... the unrelated payment/order APIs"), so nothing upstream
of these two handlers ever verified the caller.
Fix: both GET handlers now call the same fail-closed Zitadel verifier
/api/0pt/* relies on (resolveAuthContext, src/auth/context.ts) directly, via
a new thin wrapper (src/auth/require-route-auth.ts) that maps a rejected
decision to the same 401/403 JSON shape middleware.ts already returns. The
wrapper re-verifies the bearer token itself rather than trusting any
x-0pt-verified-* header on the request, since middleware never runs in front
of these routes to overwrite a client-supplied one.
POST /api/orders (anonymous draft/quote creation before the deposit-payment
step) is intentionally left as-is -- only the read paths that leaked data are
gated. Tracked as part of docs/compliance/BACKLOG.md P0-3.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
31 lines
1.2 KiB
TypeScript
31 lines
1.2 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server";
|
|
import { listOrders } from "@/lib/orders-store";
|
|
import { requireRouteAuth } from "@/src/auth/require-route-auth";
|
|
|
|
// GET /api/admin/metrics — order queue + financial aggregates for the admin
|
|
// dashboard. Outside middleware.ts's matcher (/api/0pt/:path* only) and
|
|
// previously unauthenticated entirely, so auth is enforced here directly via
|
|
// the same fail-closed Zitadel verifier — see src/auth/require-route-auth.ts.
|
|
export async function GET(req: NextRequest) {
|
|
const auth = await requireRouteAuth(req);
|
|
if (auth.response) return auth.response;
|
|
const orders = await listOrders();
|
|
const byStatus: Record<string, number> = {};
|
|
let depositPaidOre = 0;
|
|
let pipelineOre = 0;
|
|
for (const o of orders) {
|
|
byStatus[o.status] = (byStatus[o.status] ?? 0) + 1;
|
|
if (o.status !== "draft") depositPaidOre += o.deposit_ore ?? 0;
|
|
pipelineOre += o.total_ore ?? 0;
|
|
}
|
|
return NextResponse.json({
|
|
total: orders.length,
|
|
by_status: byStatus,
|
|
in_production: byStatus["in_production"] ?? 0,
|
|
review: byStatus["review"] ?? 0,
|
|
delivered: byStatus["delivered"] ?? 0,
|
|
deposit_paid_ore: depositPaidOre,
|
|
pipeline_ore: pipelineOre,
|
|
});
|
|
}
|